Clicking object lot link results in "Something went wrong" broken link

monica

I have had a chance to look at the default theme to see where it might be getting caught.

in Browse/browse_results_list_html.php or Browse/browse_results_images_html.php depending which view you are using for ca_object_lots.

Find the line (around line 82-83) that has

if ($vs_table != 'ca_objects'){

and add ca_object_lots to the exclusion. eg.

if ($vs_table != 'ca_objects' && $vs_table != 'ca_object_lots') {

you could also change it to use an array to check too

if (!in_array($vs_table, ['ca_objects','ca_object_lots'])) {

The error comes from the caGetDisplayImagesForAuthorityItems() function that goes and gets the media from related object records to use as the thumbnail, but object lots don't work that way. If you want an image from a related object in the search results, you will have to insert your own code to do that.

hdace

monica If you want an image from a related object in the search results, you will have to insert your own code to do that

I am very grateful that it works now. Thank you!

So... I've tried messing around but I can't work out what code, and where it would go, to get thumbnail images. Right now the results have empty image containers

darrigan

Thanks to Monica, it works!

monica

I had an error in one of my code snippets (&& instead of ||). I edited my post with the correct operator.

darrigan

monica Are you sure of that?
Because with && the code is running well, but with || it gives an error.
Also:
!in_array($vs_table, ['ca_objects','ca_object_lots'])
is like:
not (A or B) = (not A) and (not B)
So:
$vs_table != 'ca_objects' && $vs_table != 'ca_object_lots'
is good! 🤔

monica

darrigan Yes, you're correct, I was right in the first place. Brain getting mixed up because of the NOT operator. Serves me right for doing it just before bed.

hdace

Yes it’s true the first solution monica listed did not work for me; the second array code did work. But I’m getting no images in the image containers

darrigan

Try this.
You need to edit the UI interface for object_lots in order to add the possibility to link a representation.
Manage > Administration > User interfaces > Object lots editor
In a bundle (Basic info for example), drop the "Object lot media representations" to the right side. Save.
(Or you can also edit the UI for Object representation editor and add the "Object representation Object lot".)
Now you can add edit a lot and add an image, exactly as you should do for an object.
(Or you can edit a representation and link it to a lot.)

Next, you need to modify this code:

Go to: /themes/<your_theme>/views/Browse
Edit (and make a copy in case of...) the file browse_results_list_html.php, at about the line 123:
Replace
$vs_image = ($vs_table === 'ca_objects')
by
$vs_image = ($vs_table === 'ca_objects' or $vs_table === 'ca_object_lots')

And now, you should have a browse by object_lots with your image in the container.

I tried it in my production instance, CA 1.7.17): it works.
(Look here: https://collections.univ-pau.fr/pub/index.php/Browse/object_lots I made public only 2 lots just for few days.)

hdace

darrigan You need to edit the UI interface for object_lots

I spent some time trying to do this. I believe we're using two different CA versions. I'm on 2.0.8. There is no item "Object lot media representations" available when I click on the Basic info bundle in the Object lot editor. There many similar items, but none with that exact name. There is also no item "Object representation Object lot" in any of the bundles in the Object representation editor. I tried to work out how to add a MEDIA interface to Object lot editing interfaces but it just never shows up. I don't know if version 2 of CA allows one to add an image to an Object Lot...

monica

brucek Is this a patch to allow object lots to get related object representations? If this works for all records types (objects, lots, entities, collections, occurrences etc...), then you should submit this patch to the pawtucket repository for all to use.

brucek

monica

I believe this will work for all record types. It feels too much like a hack so I havent submited it as a patch...but I can.

darrigan

Are you available to do a video call to see if I can help you live? If yes, send me an email to my name arobase univ-pau dot fr.

hdace

darrigan I may do that but I have actually made progress. One of the items I added worked after I gave administrator access (off by default!).

I have now successfully added an object representation to two lots. I also updated the code you suggested. But still no image in results image container for those two lots. I saw that it worked on your website. I'll keep trying for now...

hdace

darrigan do a video call

Tried to send you an email but it bounced. I may have gotten the address wrong. I put an at sign in between the a word and the u word. Isn't that right?

darrigan

hdace If you add an object representation to your lot, don't forget to set its status to "public".

(My address is on this page (in french): https://collections.univ-pau.fr/pub/index.php/About/Index just replace "chez" by @.)

monica

brucek it’s not for me to say. But you could at least put it up to be reviewed. Just make sure you explain the issue you are trying to solve.

darrigan

Hi Brucek,

brucek $tbl = ( $vs_linking_table != "ca_objects") ? "ca_objectsx" : "ca_objects"; //pelhamhs

Could you explain me why you write ca_objectsx here? 🤔

brucek

darrigan
If I dont make the substitution then I get an SQL error:

#1066 - Not unique table/alias: 'ca_objects'

i.e.:
SELECT DISTINCT ca_object_representations.media, ca_object_lots.lot_id
FROM ca_object_lots
INNER JOIN ca_objects ON ca_objects.lot_id = ca_object_lots.lot_id
INNER JOIN ca_objects ON ca_objects.object_id = ca_objects.object_id
INNER JOIN ca_objects_x_object_representations ON ca_objects_x_object_representations.object_id = ca_objects.object_id
INNER JOIN ca_object_representations ON ca_object_representations.representation_id = ca_objects_x_object_representations.representation_id
WHERE ca_objects_x_object_representations.is_primary = 1 AND ca_objects.access IN (1) AND ca_object_representations.access IN (1) AND ca_object_lots.lot_id IN (1083) LIMIT 0, 25

throws an error.

This is my hack:
SELECT DISTINCT ca_object_representations.media, ca_object_lots.lot_id
FROM ca_object_lots
INNER JOIN ca_objects ON ca_objects.lot_id = ca_object_lots.lot_id
INNER JOIN ca_objects as ca_objectsx ON ca_objectsx.object_id = ca_objects.object_id
INNER JOIN ca_objects_x_object_representations ON ca_objects_x_object_representations.object_id = ca_objects.object_id
INNER JOIN ca_object_representations ON ca_object_representations.representation_id = ca_objects_x_object_representations.representation_id
WHERE ca_objects_x_object_representations.is_primary = 1 AND ca_objectsx.access IN (1) AND ca_object_representations.access IN (1) AND ca_object_lots.lot_id IN (1083);

darrigan

@monica Do you know how is it possible, in thebrowse_results_list_html.php file, to get the primary image of the first object contained in a certain lot?
This could be a possible way to display a default image as a lot's representation. (Instead of assign images by hand for 600+ lots🙃)

Hal and I did a video call today to try to solve his image display problem for a lot. After trials and errors, we found that one action solved the problem: we need to click on "make primary" when linking a media to the lot. Without that, the image doesn't display...

darrigan

@hdace Hi, I've been thinking about your request to associate an image with each lot, using an image extracted from an object in the batch, without having to do it by hand.
I saw on your site that you started doing it "by hand" and the result is superb! https://rchsdigitalcollections.epistrophypictures.com/index.php/Browse/lots
If you spend 2-3 minutes manually assigning an image for 666 batches, you will spend about 30 hours of work 😅

You can do this in several ways, more or less conventional.

The most conventional method would be to import from an Excel file that associates a lot identifier with a media identifier, if you already have this easy-to-create relationship... But this requires first doing an exportation of the listing of images' identifiers of the objects contained in each lot and sorting them to keep only one by lot.

The other less conventional method would be to create a script that executes a SQL query to retrieve the identifier of the first public image (or "primary") of the first public object that is in a lot, and to create a new row in the ca_object_lots_x_object_representations table, without going through the providence official tools... There is always a risk in wanting to tamper with the database, unless you make a backup copy just before, in case it goes wrong... (it should demand less than 30h of work, except in case of crash 😁)

« Previous Page Next Page »