Clicking object lot link results in "Something went wrong" broken link

hdace

darrigan Also: why don't you allow people to browse your collection by sources (lots)?

I've mostly fixed non-appearance of results by getting rid of #'s from lot names. I deleted them and re-uploaded them with a corrected xlsx database.

But now I'm looking at your question about browsing lots. I've been messing around with editing the browse.conf in the pawtucket themes conf folder. If I enter table = ca_entities or ca_places, I get results. But if I enter table = ca_object_lots I get a broken page. So it looks like that table is unbrowsable?

If you go to
https://rchsdigitalcollections.epistrophypictures.com
and click on Browse, you'll see I've made the name Donors. So is there a fix for this? Thanks!

darrigan

I tried for my site: I'm not able to browse by object_lots, even if I add the attended parts in app/browse.conf and themes/<my_theme>/conf/browse.conf 🤔

@seth: do you know how can we acheive this?
Why is there no ca_object_x_object_lots or ca_object_lots_x_objects table? 🤔 How do you "link" objects with lots?

monica

darrigan What is in the browse.conf settings? There is no ca_object_x_object_lots because this is an intrinsic relationships which is a one to many (Object lots can have many objects, but each object can only have one object_lot), compared to other relationships in the system which are many to many.

You get the lot through the object using lot_id and ca_object_lots have a idno_stub instead of idno

hdace

monica The fact remains that visitors to our website will want to browse by lot donors. Residents of our county will want to browse a list of donors, recognize a family name they're familiar with, and click on it to see the pictures of that family.

If you go to our website and click on Browse, then click on Donors, you get a broken page. I tried to get that page to work by going into this configuration file: themes/<my_theme>/conf/browse.conf and adding this code:

Lots = {
displayName = _(Donors),
labelSingular = _("donor"),
labelPlural = _("donors"),
table = ca_object_lots,
restrictToTypes = [],
showLetterBarFrom = ca_object_lots.preferred_labels,
showLetterBarSorts = [ca_object_lots.preferred_labels],

views = {
	images = {}, 
	list = {}
},

sortBy = {
	Relevance = _natural,
	Identifier = ca_object_lots.idno_stub,
	Name = ca_object_lots.preferred_labels
},

(I can't get the code to display correctly)

Not being a website coder, I realize I may have done something wrong. But I would appreciate, if you can, an explanation as to why our visitors can't browse by lot. Thanks!

monica

hdace without looking at the code for your site we can’t for certain tell you what’s wrong. It is capable of showing lots however.

My assumption would be something in the Browse/browse_results_html.php or Browse/browse_results_images_html.php is conflicting with your config or with lots in particular.

Do you have any facets configured? Have you tried removing the letter bar settings?

hdace

monica without looking at the code for your site

Most of the code for the site is vanilla. The only relevant change was adding the code I quoted above.

I looked at Browse/browse_results_html.php and Browse/browse_results_images_html.php but I could not see any conflict. They have never been edited (or copied to the relevant custom theme directory).

I tried adding facets to app/conf/browse.conf but it didn't work. darrigan tried that previously and also couldn't get it to work, as is mentioned above.

Yes, I did try removing the letter bar settings. No joy.

I don't see any way forward with this problem.

hdace

monica It is capable of showing lots

Apparently Pawtucket can browse lots. darrigan's idea of using entities through types is interesting, except I don't know how to do that.

And I totally don't understand brucek's answer.

darrigan

I think the problem comes from table = ca_object_lots and I don't know how to browse lots...

In your case, hdace, why did you choose to enter your donors as "object_lots", instead of "entities" (which refers to people)?
You could create two types of entities: types "donor" and type "photographer". And so, you could browse images by type "donor" or by type "photographer". (And no use of object_lots.)

brucek

what I did was to modify /app/helpers/themeHelper.php

~ line 928:
$tbl = ( $vs_linking_table != "ca_objects") ? "ca_objectsx" : "ca_objects"; //pelhamhs
if($pa_options['checkAccess']){
$vs_access_wheres = " AND {$tbl}.access IN (".join(",", $pa_access_values).") AND ca_object_representations.access IN (".join(",", $pa_access_values).")"; //pelhamhs
}

~ line 1014:
$vs_sql = "SELECT DISTINCT ca_object_representations.media, {$vs_table}.{$vs_pk}
FROM {$vs_table}
INNER JOIN {$vs_linking_table} ON {$vs_linking_table}.{$vs_pk} = {$vs_table}.{$vs_pk}
INNER JOIN ca_objects as {$tbl} ON {$tbl}.object_id = {$vs_linking_table}.object_id
INNER JOIN ca_objects_x_object_representations ON ca_objects_x_object_representations.object_id = ca_objects.object_id
INNER JOIN ca_object_representations ON ca_object_representations.representation_id = ca_objects_x_object_representations.representation_id
WHERE
ca_objects_x_object_representations.is_primary = 1 {$vs_access_wheres} {$vs_rel_type_where} {$vs_type_where} {$vs_id_sql}
"; //pelhamhs

monica

brucek Is this a patch to allow object lots to get related object representations? If this works for all records types (objects, lots, entities, collections, occurrences etc...), then you should submit this patch to the pawtucket repository for all to use.

darrigan

Hi Brucek,

brucek $tbl = ( $vs_linking_table != "ca_objects") ? "ca_objectsx" : "ca_objects"; //pelhamhs

Could you explain me why you write ca_objectsx here? 🤔

darrigan

Assuming you want to turn all object_lots into entities, it would be unreasonable to do it by hand! 🙃

How was created your database?

Did you import data from a big file like excel tab with the import function?
Did you add each record by hand?

hdace

darrigan With an Excel file containing 12,050 records. So yes would not be good to do individually. I realize maybe reinstalling from scratch with a better mapping arrangement might solve this problem. But since the data are already there, it would be nice if they were browsable.

darrigan

hdace
I agree that in the logic of collection management, each donation corresponds to a lot. But if in your case the lots are equivalent to people or org entities, we can consider the idea I propose.
If you are motivated to do an import from scratch, after changing the object_lots to entities, I think this would be the best solution for browsing through.

"To do and undo is still work"😅

monica

I have had a chance to look at the default theme to see where it might be getting caught.

in Browse/browse_results_list_html.php or Browse/browse_results_images_html.php depending which view you are using for ca_object_lots.

Find the line (around line 82-83) that has

if ($vs_table != 'ca_objects'){

and add ca_object_lots to the exclusion. eg.

if ($vs_table != 'ca_objects' && $vs_table != 'ca_object_lots') {

you could also change it to use an array to check too

if (!in_array($vs_table, ['ca_objects','ca_object_lots'])) {

The error comes from the caGetDisplayImagesForAuthorityItems() function that goes and gets the media from related object records to use as the thumbnail, but object lots don't work that way. If you want an image from a related object in the search results, you will have to insert your own code to do that.

hdace

monica If you want an image from a related object in the search results, you will have to insert your own code to do that

I am very grateful that it works now. Thank you!

So... I've tried messing around but I can't work out what code, and where it would go, to get thumbnail images. Right now the results have empty image containers

darrigan

Thanks to Monica, it works!

monica

I had an error in one of my code snippets (&& instead of ||). I edited my post with the correct operator.

darrigan

monica Are you sure of that?
Because with && the code is running well, but with || it gives an error.
Also:
!in_array($vs_table, ['ca_objects','ca_object_lots'])
is like:
not (A or B) = (not A) and (not B)
So:
$vs_table != 'ca_objects' && $vs_table != 'ca_object_lots'
is good! 🤔

monica

darrigan Yes, you're correct, I was right in the first place. Brain getting mixed up because of the NOT operator. Serves me right for doing it just before bed.

hdace

Yes it’s true the first solution monica listed did not work for me; the second array code did work. But I’m getting no images in the image containers

darrigan

Try this.
You need to edit the UI interface for object_lots in order to add the possibility to link a representation.
Manage > Administration > User interfaces > Object lots editor
In a bundle (Basic info for example), drop the "Object lot media representations" to the right side. Save.
(Or you can also edit the UI for Object representation editor and add the "Object representation Object lot".)
Now you can add edit a lot and add an image, exactly as you should do for an object.
(Or you can edit a representation and link it to a lot.)

Next, you need to modify this code:

Go to: /themes/<your_theme>/views/Browse
Edit (and make a copy in case of...) the file browse_results_list_html.php, at about the line 123:
Replace
$vs_image = ($vs_table === 'ca_objects')
by
$vs_image = ($vs_table === 'ca_objects' or $vs_table === 'ca_object_lots')

And now, you should have a browse by object_lots with your image in the container.

I tried it in my production instance, CA 1.7.17): it works.
(Look here: https://collections.univ-pau.fr/pub/index.php/Browse/object_lots I made public only 2 lots just for few days.)

hdace

darrigan You need to edit the UI interface for object_lots

I spent some time trying to do this. I believe we're using two different CA versions. I'm on 2.0.8. There is no item "Object lot media representations" available when I click on the Basic info bundle in the Object lot editor. There many similar items, but none with that exact name. There is also no item "Object representation Object lot" in any of the bundles in the Object representation editor. I tried to work out how to add a MEDIA interface to Object lot editing interfaces but it just never shows up. I don't know if version 2 of CA allows one to add an image to an Object Lot...

« Previous Page Next Page »