Translating form elements for print summary options form

theCA

While printing a PDF from summary of an object, after clicking in the upper right corner in the page icon with the adobe pdf (Download summary as PDF) i get the download options windows.
After selecting PDF under "Format" combo i get the options extracted from the @params in printTemplates/summary/ca_objects_summary.php.
I want those options to also be translated when the language is changed in the preferences.
What i did:

I created the entry in the .po/.mo file for the language
Edited line 845 (this is for checkbox only, for testing purposes) of file app/helpers/printHelpers.php from:
$form_elements[$n] = ['label' => $p['label'], 'element' => $e];
to
$form_elements[$n] = ['label' => _t($p['label']), 'element' => $e];

But until now i didnt get any result, i tried to clean caches and Ctrl+F5 or Ctrl+Shift+R in the browser but i still see the chechboxes in english.
Any advice?

seth

There is currently no provision for translating those options. Changing the code as you've done won't really work. We'll add syntax to support localization. Please create a GitHub issue for it if you can.

theCA

Issue #1620 opened.
Thanks1

seth

Just pushed a change to support localization here. Information as to how it works is at https://github.com/collectiveaccess/providence/issues/1620

theCA

Thanks!!
I will update the following files of my deb/php8 installation:

app/helpers/printHelpers.php
app/helpers/displayHelpers.php

The options in:

printTemplates/summary/ca_objects_summary.php

And confirm